Use the radix-4 FFT for odd powers of two #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
- Coverage 98.04% 97.96% -0.08%
==========================================
Files 4 4
Lines 409 393 -16
==========================================
- Hits 401 385 -16
Misses 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andreasnoack
force-pushed
the
an/pow24v2
branch
7 times, most recently
from
447a9c1 to
693c9c4
Compare
Collaborator
|
Happy to approve, but at this point do you think we should just kill the general pow2 code since this subsumes? |
Member
Author
|
I actually did that in a first version but then added it back in because I wasn't sure if there'd be situations where it would be a better choice. Let me drop it as it reduces the code. If we need it again at some point, it can easily be recovered. |
This seems to cut the runtime for odd powers of two by more the two.
andreasnoack
force-pushed
the
an/pow24v2
branch
from
693c9c4 to
bc7ed03
Compare
dannys4
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to cut the runtime for odd powers of two by more the two.